> On March 11, 2017, 5:44 p.m., Albert Astals Cid wrote: > > Patch doesn't apply to current master > > Oliver Sander wrote: > I was going to rebase the patch and post it again, but it really doesn't > make any sense anymore. Basically all the patch does is add a line > > m_tabWidget->setAutomaticResizeTabs( true ); > > but that method has been removed in Qt5, and I could not find an obvious > easy replacement. A different approach seems to be necessary.
Should we just discard this then? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128062/#review102798 ----------------------------------------------------------- On May 30, 2016, 9:23 p.m., torham zed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128062/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 9:23 p.m.) > > > Review request for Okular. > > > Bugs: 363513 > http://bugs.kde.org/show_bug.cgi?id=363513 > > > Repository: okular > > > Description > ------- > > A pdf with a very long name can crowd out pdfs with short names in the row of > tabs. > > > Diffs > ----- > > home/user/projects/OkularOriginal/shell/shell.cpp d80def4 > > Diff: https://git.reviewboard.kde.org/r/128062/diff/ > > > Testing > ------- > > I used several PDF files of short/long name. > > https://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKTabWidget.html > > The setAutomaticResizeTabs() call appeared to work much better with > setElideMode disabled. I commented out the line and left it in place. > > > Thanks, > > torham zed > >
