rkflx created this revision. Restricted Application added a project: Okular.
REVISION SUMMARY In some languages the sidebar container header is wider than the minimum container width and therefore cut off. By removing the explicitly set minimum width, the QVBoxLayout is now allowed to actually do its job of automatically calculating the proper minimum width. In times of HiDPI screens, setting the maximum width to 600px seems arbitrary and overly restrictive, so it is removed. Both width restrictions were originally chosen in https://phabricator.kde.org/R223:078b81b7807d6af600474e40a8ce62525a46ce4e with no explanation given for the values selected, which later were changed to different values multiple times. Today, they simply do not seem necessary anymore. Note: The minimum size for some languages is now wider than before, still acceptable though (see screenshots of Greek, where the translated string of "Thumbnails" is one of the longest between all languages). Most languages are not affected at all. BUG: 176780 TEST PLAN Use default fonts, change application language to Greek. Move splitter left (text in header of thumbnail sidebar not cut off anymore) and right (does not stop at 600px). Window resizing works as expected. | Before | After | | F3810783: okular-min-before.png <https://phabricator.kde.org/F3810783> | F3810784: okular-min-after.png <https://phabricator.kde.org/F3810784> | REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D6696 AFFECTED FILES ui/sidebar.cpp To: rkflx, #okular Cc: aacid
