----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129386/#review100847 -----------------------------------------------------------
See https://git.reviewboard.kde.org/r/124069/ - Albert Astals Cid On Nov. 12, 2016, 8:29 p.m., Oliver Sander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129386/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2016, 8:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > The new menu entry does the same as file -> saveAs, but using the name that > was used to open the file. > > It seems to work nicely, but two minor questions remain: > > - The new menu entry gets the shortcut KStandardShortcut::Save. But file -> > saveAs already had that shortcut, so I change that to > KStandardShortcut::SaveAs. Now that clashes with the shortcut for file -> > saveCopyAs, but I am unable to simply remove the shortcut for that one. > Simply removing the line that sets it doesn't do anything (for me). > - part.cpp contains a method 'saveFile' which is apparently not used from > within okular itself. All it does is to write a note saying "okular doesn't > support saving". Is there anything I need to do with that method? > > Thank you for your reviewing time. > > > Diffs > ----- > > part.h 4e8bef1 > part.cpp 26128c1 > part.rc 34a1160 > > Diff: https://git.reviewboard.kde.org/r/129386/diff/ > > > Testing > ------- > > > Thanks, > > Oliver Sander > >
