----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126406/#review97971 -----------------------------------------------------------
home/user/projects/OkularOriginal/shell/shell.cpp (line 499) <https://git.reviewboard.kde.org/r/126406/#comment65998> Don't use magic numbers. Write it return result == KMessageBox::Yes; - Anthony Fieroni On Юни 1, 2016, 3:08 преди обяд, torham zed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126406/ > ----------------------------------------------------------- > > (Updated Юни 1, 2016, 3:08 преди обяд) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 334019 > http://bugs.kde.org/show_bug.cgi?id=334019 > > > Repository: okular > > > Description > ------- > > Multi tab popup warning > > > Diffs > ----- > > home/user/projects/OkularOriginal/shell/shell.cpp d80def4 > > Diff: https://git.reviewboard.kde.org/r/126406/diff/ > > > Testing > ------- > > Opened several pdf files, closed entire program with multiple files open to > see if popup properly functions along with the 'yes' and 'no' buttons. > > > Thanks, > > torham zed > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
