-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127636/
-----------------------------------------------------------
(Updated July 19, 2016, 6:42 p.m.)
Review request for Okular and Albert Astals Cid.
Changes
-------
Fix issues reported by Anthony Fieroni.
Bugs: 361644
http://bugs.kde.org/show_bug.cgi?id=361644
Repository: okular
Description
-------
When an annotation has revisions, display them in the
popup window and allow the user to edit their contents.
This is just a first step towards a better review workflow.
What remains to be done:
- hide the revision annotations (the revisions should only
be shown in the popup they are revisions of; not separately
because this may lead to e.g. overlapping icons when an annotation
and its revision have the same position on the page); this would
conform to the spec, see e.g. the comments to the R key in
table 8.21 on p. 620 of the 1.7 revision of the spec)
- allow setting the revision status (i.e.
Accepted/Rejected/Canceled/Completed/None;
Marked/Unmarked; see pdf spec table 8.22 on p. 620 of 1.7 revision of the
spec)
- allow adding revisions; this will need changes to poppler
as it currently does not allow setting the IRT key; I am working
on a patch and I will post it to the poppler mailing list when I
am satisfied with it
Diffs (updated)
-----
generators/poppler/generator_pdf.cpp a65487af06a221cf7faf72e108aa1f04e1b91b04
Diff: https://git.reviewboard.kde.org/r/127636/diff/
Testing
-------
Opened a file with annotation revisions and tested that they can be edited and
properly saved back.
File Attachments
----------------
Test file with annotation revisions.
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/11/2f84d42c-e317-4d3e-968b-8b873945d51a__test.pdf
Thanks,
Jonathan Verner
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
