> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) > > Albert Astals Cid wrote: > that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog > i guess? Is it really supposed to be that ugly? > > Aleix Pol Gonzalez wrote: > You don't have it set up properly, you should be getting the normal > KFileWidget-based dialog. > > Albert Astals Cid wrote: > I know i don't have it setup to give me the "Plasma experience", it's > giving me the "Okular experience outside plasma", and it is a serious > regression to what we have by using KFileDialog, don't you think? > > Aleix Pol Gonzalez wrote: > As I see it, there's no non-_Plasma Experience_. In Gnome, it should use > the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or > Android, whatever they use there: so it's not a regression but a feature. > > Albert Astals Cid wrote: > There's more things in Linux land than Plasma and Gnome, i'm worried > about such an ugly dialog for those people. > > Aleix Pol Gonzalez wrote: > Let's create a wiki for them to install the Plasma integration? This way > they'll be fixing all of it, not just this precise dialog. > > Or I can discard this review and port it to use KFileWidget. Or > undeprecate KFileDialog?
Any idea why i have 3 commic book entries and 2 PDF entries? http://i.imgur.com/trqsguU.png - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127021/#review92202 ----------------------------------------------------------- On Feb. 10, 2016, 2:23 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127021/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 2:23 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Drops KDELibs4Support usage, mostly it wasn't actually used, except for that > KFileDialog usage that I ported. > > > Diffs > ----- > > shell/shell.cpp c97054a > > Diff: https://git.reviewboard.kde.org/r/127021/diff/ > > > Testing > ------- > > Opening dialog seems to work fine, tests still pass except for parttest, but > I'm unsure it's related: https://paste.kde.org/p37pdubgf > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
