> On mar. 30, 2015, 6:11 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3846 > > <https://git.reviewboard.kde.org/r/122752/diff/3/?file=355849#file355849line3846> > > > > Where does this 5 come from? > > Albert Astals Cid wrote: > ping? > > Pulkit Gupta wrote: > Sir, the mouse cursor will change as soon as its 5 units near the end of > document (bottom or right end). Setting it to lower value caused mouse cursor > not changing when user moved its mouse at a fast rate and setting it at > higher value would change the mouse cursor appearance even before when its > near to the end of document. Therefore I put the distance value from > bottom/right edge to 5 units (I think of it as optimum value).
Why 5 and not 6? or 4? or 33? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122752/#review78239 ----------------------------------------------------------- On mar. 20, 2015, 7:41 a.m., Pulkit Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122752/ > ----------------------------------------------------------- > > (Updated mar. 20, 2015, 7:41 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 334798 > http://bugs.kde.org/show_bug.cgi?id=334798 > > > Repository: okular > > > Description > ------- > > Solved the bug where mouse cursor appearance was not changing (when selected > Selection Tool) when hovering over certain areas in okular. > > > Diffs > ----- > > ui/pageview.cpp 49d6f8a > > Diff: https://git.reviewboard.kde.org/r/122752/diff/ > > > Testing > ------- > > > Thanks, > > Pulkit Gupta > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
