----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122787/#review77595 -----------------------------------------------------------
Can you write an auto test for this? This sidebar thing breaks a lot, having it auto tested would be great. See the tests/ folder. - Albert Astals Cid On mar. 3, 2015, 12:20 p.m., Pulkit Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122787/ > ----------------------------------------------------------- > > (Updated mar. 3, 2015, 12:20 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 344599 > http://bugs.kde.org/show_bug.cgi?id=344599 > > > Repository: okular > > > Description > ------- > > Previously, thumbnails side container was opened by default at start up. Now > Okular will save in settings that when last session was closed, was side > container being displayed or not. And will display or hide the side container > at next session accordingly. > > > Diffs > ----- > > conf/okular.kcfg f980989 > part.cpp 36438af > ui/sidebar.cpp 0c722a9 > > Diff: https://git.reviewboard.kde.org/r/122787/diff/ > > > Testing > ------- > > Tested that > ==>when Side container is open, at next start, Side container will open > ==>If user closes Side container, at next start, Side container will remain > closed > > > Thanks, > > Pulkit Gupta > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
