----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118293/#review64137 -----------------------------------------------------------
Ship it! The issues previously found are now (version 2) fixed, a quick testing shows no regressions and the code Small behavioral change: missing properties for TIFF images do not display "Unknown" anymore. If a field is missing/not provided by the TIFF file, the corresponding line in the properties dialog is simply not shown. Feel free to commit after checking/fixing the points below. core/document.h <https://git.reviewboard.kde.org/r/118293/#comment44790> If this is now going to master, all occurrencies of 4.14/0.20 should be updated (tried to mark all of them, I could have missed some). core/document.h <https://git.reviewboard.kde.org/r/118293/#comment44791> See above core/document.h <https://git.reviewboard.kde.org/r/118293/#comment44792> See above core/document.h <https://git.reviewboard.kde.org/r/118293/#comment44793> See above core/document.h <https://git.reviewboard.kde.org/r/118293/#comment44794> See above - Luigi Toscano On Aug. 9, 2014, 10:58 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118293/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2014, 10:58 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > DocumentInfo is now QMap based instead of XML based. Makes internal handling > easier. The generators don't do any caching anymore since the Document was > already doing caching, made no sense. Now we only ask for the keys we need > (except the properties dialog) so the generators that are slow can decide to > return only what was asked for. Some generators (i.e. unpluck, xps or the > text based ones) will still return all the info since it's calculated on load > time and it's not time consuming to return everything if we already have it. > > > Diffs > ----- > > generators/xps/generator_xps.h 4c56e8c > generators/xps/generator_xps.cpp 2399a96 > part.cpp d9f1682 > ui/presentationwidget.cpp 4aaec2a > ui/propertiesdialog.cpp 485c2de > generators/fax/generator_fax.h 1cb7d22 > generators/fax/generator_fax.cpp 38873ef > generators/kimgio/generator_kimgio.h faebd85 > generators/kimgio/generator_kimgio.cpp f856434 > generators/plucker/generator_plucker.h 8dac4b8 > generators/plucker/generator_plucker.cpp 4ffdead > generators/poppler/generator_pdf.h 1a34bb7 > generators/poppler/generator_pdf.cpp c978b09 > generators/spectre/generator_ghostview.h ab9c33d > generators/spectre/generator_ghostview.cpp 7b0146a > generators/tiff/generator_tiff.h 9ad1de6 > generators/tiff/generator_tiff.cpp bc692de > generators/chm/generator_chm.cpp 84b9dde > generators/djvu/generator_djvu.h 93ee4de > generators/djvu/generator_djvu.cpp c506ce3 > generators/dvi/generator_dvi.h d7bf8fd > generators/dvi/generator_dvi.cpp 166a905 > core/document.h 06bac8a > core/document.cpp 99e0563 > core/document_p.h 08775da > core/generator.h 506f8a8 > core/generator.cpp ec1d1f7 > core/script/kjs_document.cpp c3280cd > core/textdocumentgenerator.h ec331d6 > core/textdocumentgenerator.cpp d598ccc > generators/chm/generator_chm.h 5d97009 > > Diff: https://git.reviewboard.kde.org/r/118293/diff/ > > > Testing > ------- > > Opened a few files, works as it did. Added some extra debug, made sure that > only the info we want is asked for, and that it's properly cached. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
