> On Feb. 20, 2014, 11:10 p.m., Albert Astals Cid wrote: > > I think that making the generators not depend in qtwidgets is a good idea. > > OTOH if the guy has disabled "Show hints and info messages" he won't see > > the error. Maybe you should change also in this review that error messages > > are shown whenever you have that "Show hints and info messages" enabled or > > disabled? > > Luigi Toscano wrote: > According the code here: > http://lxr.kde.org/source/kde/kdegraphics/okular/ui/pageview.cpp#709 > even if "Show hints and info messages" is disabled, a KMessageBox is > displayed for errors (not warnings and info, which are discarded). I tested > it (with the same 'dvips' test) and it works.
Somehow i was too tired the other day when i tried it and didn't see the message box :D - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115925/#review50421 ----------------------------------------------------------- On Feb. 20, 2014, 9:22 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115925/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 9:22 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Reduce the number of KMessageBox for information/error and change them into > signals for PageViewMessage. > The proper signals are propagated. > > Few strings have been adapted or outdated information have been removed. > > > This is just the beginning of a series of similar cleanup. I'm posting the > first one to get feedback on this solution :) > > > Diffs > ----- > > generators/dvi/generator_dvi.cpp c666933 > generators/dvi/psgs.h 6842a94 > generators/dvi/psgs.cpp f54d78e > generators/dvi/dviexport.cpp c35f4b4 > generators/dvi/dviRenderer.h 842c11e > generators/dvi/dviRenderer.cpp 4513ee2 > generators/dvi/dviexport.h 3265645 > > Diff: https://git.reviewboard.kde.org/r/115925/diff/ > > > Testing > ------- > > Temporarily remove the dvips executable and try to print a DVI file. > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
