----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113973/ -----------------------------------------------------------
(Updated Feb. 22, 2014, 5:27 p.m.) Review request for Okular. Changes ------- Port to tiles. Removed unnecessary extra render, when the magnifier is not visible. There is still one issue though. Magnifier has to send request for pixmap with NormalizedRect containing full page, otherwise only the corner gets rendered in highres (?). Need to investigate this further to speed up the rendering. Repository: okular Description ------- I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it. The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward. The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another. So the remaining question is, what is the status of this: core/document_p.h:213 "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one" Is someone working on it? Diffs (updated) ----- CMakeLists.txt 63d2922 conf/okular.kcfg f954c9a ui/magnifierview.h PRE-CREATION ui/magnifierview.cpp PRE-CREATION ui/pageview.h 9c15af6 ui/pageview.cpp 7c7f785 Diff: https://git.reviewboard.kde.org/r/113973/diff/ Testing ------- Thanks, Michal Humpula
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
