----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/#review49311 -----------------------------------------------------------
ui/presentationwidget.cpp <https://git.reviewboard.kde.org/r/115532/#comment34805> Do you think you could use m_transitionTimer instead of your own timer? ui/presentationwidget.cpp <https://git.reviewboard.kde.org/r/115532/#comment34804> please follow the indentation of the rest of the file - Albert Astals Cid On Feb. 7, 2014, 8:55 a.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115532/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 8:55 a.m.) > > > Review request for Okular. > > > Bugs: 317073 > http://bugs.kde.org/show_bug.cgi?id=317073 > > > Repository: okular > > > Description > ------- > > implemented fade in and fade out transition for presentation mode in okular. > > > Diffs > ----- > > ui/presentationwidget.cpp 1b63e2f > ui/presentationwidget.h c63e119 > > Diff: https://git.reviewboard.kde.org/r/115532/diff/ > > > Testing > ------- > > It works fine on my system accept for the first time in case of fade out > transition. > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
