----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114060/#review46418 -----------------------------------------------------------
This review has been submitted with commit 43246c563b2682417e11dd7a853779d40f55ed30 by Albert Astals Cid on behalf of Jon Mease to branch master. - Commit Hook On Nov. 28, 2013, 12:47 a.m., Jon Mease wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114060/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 12:47 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > This patch introduces viewport transitions for undo/redo actions on > annotations and forms. When an annotation/form action is undone/redone but > the associated annotation/form is not currently visible, the viewport is > updated to center on the undo/redo action. If the annotation/form is visible, > the viewport is not updated. > > The viewport transitions for the Find action have also been updated to this > same algorithm. Previously the viewport was moved to center on each matching > search term even if the search term was already visible in the viewport. This > lead to unnecessary viewport transitions if the search term matched several > items in a single paragraph for example. > > These proposed changes to the viewport transition behavior are consistent > with the find and undo behavior of many existing applications including Kate, > Open Office, and Foxit PDF Reader. > > > Diffs > ----- > > core/document.h fe296e0 > core/document.cpp 265ee09 > core/document_p.h 3a257de > core/documentcommands.cpp 7799bb0 > core/documentcommands_p.h fe1c577 > core/page.cpp 0bafa99 > core/utils.cpp 5dd8448 > core/utils_p.h df82fe1 > > Diff: https://git.reviewboard.kde.org/r/114060/diff/ > > > Testing > ------- > > Manual testing of the viewport behavior for find and undo/redo actions on > several documents. I also tested that the desired behavior is maintained > when documents are rotated. > > > Thanks, > > Jon Mease > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
