----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114019/#review44271 -----------------------------------------------------------
I'd prefer if you didn't use Phonon enum for this and used our own enum, that way if we ever want to rework the internal player to not use Phonon, there won't be a need to update the API. Also a @since marker is missing for the new method. - Albert Astals Cid On Nov. 22, 2013, 9:51 a.m., Egor Matirov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114019/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 9:51 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Extend AudioPlayer so that it gives info about if something is playing at the > moment or not according to GCI task: > - http://www.google-melange.com/gci/task/view/google/gci2013/5789010593054720 > > > Diffs > ----- > > core/audioplayer.h 7697562 > core/audioplayer.cpp af59588 > core/audioplayer_p.h c6d43cf > > Diff: http://git.reviewboard.kde.org/r/114019/diff/ > > > Testing > ------- > > > Thanks, > > Egor Matirov > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
