> On Oct. 25, 2013, 6:55 p.m., Albert Astals Cid wrote: > > Thanks for the patch, the code works, so that's more than enough :-) > > > > What i'd like though is not giving a default shortcut (i.e. remove the > > Ctrl+I line) so that it does not "eat" of the few precious shortcuts that > > are free. Of course if you are a user of this feature you can still go to > > the configure shortcuts and set one (or go to configure toolbars and put it > > on the toolbar). Would that be acceptable for you?
I see your point. The important thing is that people be able to add their own. It's fine by me. - Ciro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113434/#review42373 ----------------------------------------------------------- On Oct. 25, 2013, 4:02 p.m., Ciro Santilli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113434/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 4:02 p.m.) > > > Review request for Okular. > > > Bugs: 173264 > http://bugs.kde.org/show_bug.cgi?id=173264 > > > Repository: okular > > > Description > ------- > > Added default shortcut Ctrl + I for change colors. > > This should have the exact same of clicking the toolbox Settigs > Configure > Okular > Accessibility > Change colors and then clicking Ok, therefore > changing the saved configs. > > I am not sure if: > > - viewport()->update() is the right way to update the screen after this > config change? Where is the `update()` method defined? If I tracked well, > viewport() returns a DocumentViewport, which does not seem to have such a > method. > > - I placed the new feature in the right class > > but it seems to work. > > > Diffs > ----- > > ui/pageview.h fd4e3ac > ui/pageview.cpp a1ab5bd > > Diff: http://git.reviewboard.kde.org/r/113434/diff/ > > > Testing > ------- > > > Thanks, > > Ciro Santilli > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
