https://bugs.kde.org/show_bug.cgi?id=323263
Albert Astals Cid <aa...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |http://commits.kde.org/okul | |ar/dff8bf1b365f28c6a7b7d97e | |8ca2a0e579738619 --- Comment #7 from Albert Astals Cid <aa...@kde.org> --- Git commit dff8bf1b365f28c6a7b7d97e8ca2a0e579738619 by Albert Astals Cid, on behalf of Jaan Vajakas. Committed on 18/10/2013 at 14:28. Pushed by aacid into branch 'master'. Improve searching code Also simplified code a bit by removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)). (I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.) Related: bug 323262 REVIEW: 112135 M +155 -136 core/textpage.cpp M +11 -5 core/textpage_p.h M +307 -1 tests/searchtest.cpp M +1 -0 ui/videowidget.cpp http://commits.kde.org/okular/dff8bf1b365f28c6a7b7d97e8ca2a0e579738619 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel