----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/#review41052 -----------------------------------------------------------
Hi! I haven't actually tried the code yet, but I see some avoidable variables. Also, modFactor can be made const too. ui/pageview.cpp <http://git.reviewboard.kde.org/r/112370/#comment30132> Seems we don't need decFactor here, do we? ui/pageview.cpp <http://git.reviewboard.kde.org/r/112370/#comment30133> Same thing: we don't need incFactor here, do we? ui/pageview.cpp <http://git.reviewboard.kde.org/r/112370/#comment30131> Why is modFactor assigned twice? (The second assignment seems to be the right one) - Fabio D'Urso On Sept. 27, 2013, 1:21 a.m., Tingnan Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112370/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 1:21 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > BugFix 323434/323435. Zoom factor now will be properly rounded to those > "interval values" like 140%, 250%, etc, when using zoom in and out feature. > > > Diffs > ----- > > ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a > > Diff: http://git.reviewboard.kde.org/r/112370/diff/ > > > Testing > ------- > > done on local machine > > > Thanks, > > Tingnan Zhang > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
