> On March 24, 2013, 1:06 a.m., Jon Mease wrote: > > Comments on the functionality (not the implementation): > > > > 1) I'm really excited to have this functionality in Okular (My work on the > > undo functionality was also primarily motivated by the desire to replace > > Xournal with Okular for tablet PC ink document annotation). > > 2) How difficult would it be to add something like an "erase ink strokes" > > option to the tools.xml. Xournal has this option and it controls whether > > an ink stroke is fully deleted by the eraser (as you do for the other > > annotation types) or erased incrementally (your current implementation for > > ink annotations). I've found both of these settings to be quite helpful > > under different circumstances. > > Peter Grasch wrote: > To do that, we would just need to *not* treat the ink annotation as a > special case. > Btw, it would also be easy to add a "pen width" to the eraser by not > using objectRects but nearestObjectRect (iteratively for as long as distance > <= penWidth).
Peter how's the implementation of this going? Do you need anything from us or just time? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29779 ----------------------------------------------------------- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109632/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 1:26 a.m.) > > > Review request for Okular. > > > Description > ------- > > Prerequisites: Please read till the end! > > This introduces a new annotation tool: "Eraser". > > The eraser primarily erases other annotations that it comes into contact with > (shapes, lines, highlights, etc.). > > However, ink annotations are treated more like a real eraser: Existing paths > are split and unaffected parts are preserved. > This is what it looks like: http://bedahr.org/eraser.ogv > > > Example tool configuration for your tools.xml (not included in patch): > > <tool id="15" name="Eraser" pixmap="tool-eraser-okular"> > <tooltip>Eraser</tooltip> > <engine type="Eraser" /> > <shortcut>7</shortcut> > </tool> > > The eraser builds on the work for the outline selection proposed in review > request #109627. Please apply that patch before this one. > > > Diffs > ----- > > ui/pageviewannotator.cpp 7bd7496 > > Diff: http://git.reviewboard.kde.org/r/109632/diff/ > > > Testing > ------- > > While it worked fine for the few PDFs I threw at it on this relatively > powerful machine, it was pointed out to me in #okular, that calls to > modifyPageAnnotation are very expensive as poppler has to re-draw the pdf > (with the annotations) for every change. > I hope we can resume the discussion about possible improvements here. > > > Thanks, > > Peter Grasch > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
