----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111901/#review37220 -----------------------------------------------------------
Ship it! Ship It! - Jaime Torres Amate On Aug. 5, 2013, 9:56 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111901/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 9:56 p.m.) > > > Review request for Okular, Fabio D'Urso and Jaime Torres Amate. > > > Description > ------- > > This fixes the rendering problem in 321212. Why? Because what was happening > is that for some reason the middle mouse press to gets to the PageView but > not the release, this meant that the PageView got stuck into mouseMidZooming > mode and all sort of bad things happened. Now since we don't cache if the mid > mouse button is pressed (we just query it when needed) everything is better. > > Ideally i'd like to know why we get the press and not the release, but not > sure that's feasible to "fix". > > > This addresses bug 321212. > http://bugs.kde.org/show_bug.cgi?id=321212 > > > Diffs > ----- > > ui/pageview.cpp e131d1e > > Diff: http://git.reviewboard.kde.org/r/111901/diff/ > > > Testing > ------- > > Tested the issue in the bug, tested that mid mouse zooming still works. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
