----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109627/ -----------------------------------------------------------
(Updated March 23, 2013, 7:52 p.m.) Review request for Okular. Changes ------- Fixed reported issues (all but the one about distanceConsideredEqual where I'm waiting for a reply to my earlier comment) and added test case. Description ------- Multiple features in Okular require to determine what object is at a given position. Traditionally, this relied on the bounding boxes of the given object. These do not necessarily correlate with the user would expect (for example, a diagonal line of 1px has a very large bounding box). This patch implementes shape based selection for the following annotation types: Ink, Geometric, Line, Highlight. Other objects default to the old behaviour. Diffs (updated) ----- core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/area.h 4f63759 core/area.cpp d772fc0 core/page.cpp 1db2763 tests/CMakeLists.txt 6a26b3e tests/annotationstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109627/diff/ Testing ------- I tested the annotation objects above and a couple of special cases mentioned in the IRC. Thanks, Peter Grasch
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
