----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ -----------------------------------------------------------
(Updated Oct. 6, 2012, 12:49 p.m.) Review request for Okular. Changes ------- Corrected update file (okular.upd) for settings separation. kconf_update creates empty keys in the new groups even if in the old config file these keys don't exist. This behavior seems not to correspond to the behavior described in the help page (http://techbase.kde.org/Development/Tools/Using_kconf_update#Example_update_file). Since empty keys are created a script is used to remove empty keys. Again, an unexpected behavior, if the same config file is used as input/output for the script nothing happens. Thus an intermediate file is used during update (okularpartrc2). Description ------- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) ----- CMakeLists.txt a057e82 conf/okular.kcfg 9174733 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 143d598 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION okular_sep_settings.pl PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 2ef10a1 ui/presentationwidget.cpp 9ba942b Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing ------- No Thanks, Bogdan Cristea
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
