> On Aug. 29, 2012, 11:19 p.m., Albert Astals Cid wrote: > > Ok, this fixes all the "obvious" problems with the code, now there are the > > non obvious ones, like for example, we assume that there's only one part > > per process, thus the dbus api is modelled after that, exposing just one > > part and just one shell, model that is obviously broken if I commit this > > change. > > > > Question is, are you willing to work on fixing those issues after I commit > > this patch?
Yes I'd like to work on it, but I don't know much about dbus.. - Jaydeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105965/#review18264 ----------------------------------------------------------- On Aug. 22, 2012, 10:33 a.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105965/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2012, 10:33 a.m.) > > > Review request for Okular. > > > Description > ------- > > This patch is a fix for the bug-166645, as listed here > (https://bugs.kde.org/show_bug.cgi?id=166645) > > Opens a new instance of Okular for every other file that is opened. > > > Diffs > ----- > > part.h d9a5cc4 > part.cpp 7c1ca71 > shell/shell.h 8430b9c > shell/shell.cpp 8b99ce4 > > Diff: http://git.reviewboard.kde.org/r/105965/diff/ > > > Testing > ------- > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
