> On March 8, 2012, 7:39 p.m., Albert Astals Cid wrote: > > I do really think this is a bad idea, at 1920x1080 an image uses around 8M > > of memory, now go and open a 1000 page document and you need 8G of memory > > just for the images of pages... And your computer decides to either crash > > or kill Okular. > > > > Sincerely i don't think I can accept a patch that decides it wants to crash > > the computer. I understand you want more page loading, but there should be > > a limite, 50% of your system memory, or 75%, or even 90, but just asking > > for more and more memory like crazy sounds like a bad plan.
Hm yeah, you're probably right. I didn't think this through. Question is, what to change? Reducing the amount of maximum pages seems wrong to me because if you've got the memory, use it. I will take a look at the unloading and make some changes. On a side note: I wouldn't expect the operating system to crash just because a process is asking for 8GB of memory, even if I got only 4. The memory handler would just kill it, I guess. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103129/#review11243 ----------------------------------------------------------- On March 8, 2012, 10:23 a.m., Sebastian Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103129/ > ----------------------------------------------------------- > > (Updated March 8, 2012, 10:23 a.m.) > > > Review request for Okular. > > > Description > ------- > > After discovering that the aggressive behaviour in okular is not that > aggressive at all (preloads only the next 2 pages) I've written the attached > patch to add a "Greedy" option. It preloads every page into memory. > > > Diffs > ----- > > conf/dlgperformance.cpp fd0e30b > conf/dlgperformancebase.ui b022f56 > conf/okular.kcfg b1373b3 > core/document.cpp 74757f1 > ui/pageview.cpp 28835ed > ui/presentationwidget.cpp bbeb9f5 > > Diff: http://git.reviewboard.kde.org/r/103129/diff/ > > > Testing > ------- > > Tested it on my local system, I'm using the modified okular with the new > greedy option checked and don't have any issues so far. The memory > requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it > for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It > takes a while for the whole document to be prerendered but after that it > works as expected. > > > Thanks, > > Sebastian Rose > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
