> On Feb. 12, 2012, 3:43 a.m., Harsh Chouraria J wrote: > > Ship It!
Thanks for reviewing this, but in the future please refrain for doing "Ship it" in Okular, "Ship it" is for maintainers and you are not Okular one. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103941/#review10534 ----------------------------------------------------------- On Feb. 11, 2012, 5:59 p.m., David Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103941/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2012, 5:59 p.m.) > > > Review request for Okular. > > > Description > ------- > > Simplify mimetype queries. > > String comparisons are not recommended by KMimeType class. KMimeType::is() > also hadles type inheritance. E.g.: > application/x-cbt inherits application/x-tar > > > Diffs > ----- > > generators/comicbook/document.cpp 3ba7483 > > Diff: http://git.reviewboard.kde.org/r/103941/diff/ > > > Testing > ------- > > > Thanks, > > David Palacio > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
