----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103427/#review10100 -----------------------------------------------------------
Could you explain why you decided to put it in a separate toolbar and not in the existing one? A new one gives you the versatibility to put the new minibar in each of the 4 sides of the screen, but obviously you don't want it in the bottom and you don't want it on the left or right side either since it's a huuuuuuuuuuuge was of space there, so you are going to have it on top almost always. If we have it on top almost always, i think it makes sense for it to be part of the existing toolbar, so you can actually put in the order you want, e.g. after the zoom combo. What do you think? - Albert Astals Cid On Jan. 24, 2012, 10:51 a.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103427/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2012, 10:51 a.m.) > > > Review request for Okular. > > > Description > ------- > > The bug (and duplicates) suggests that the page bar which normally appears at > the bottom of the Okular window could be docked in the toolbar, in order to > save vertical screen space which is especially useful on a wide screen. This > patch implements that. > > There can only be one MiniBar in existence, because of the fixed observer ID > (which must be unique). So the page tool only appears in the toolbar if the > page bar is hidden; if it is shown, then the page number and size label > appears there as before. The MiniBar is reparented in > Part::slotShowBottomBar() when the page bar is shown or hidden. > > The page tool is placed in its own toolbar by default, so that it can be > positioned or floated in accordance with the user's preference. > > There are GUI changes and a new I18N string, so this change (if accepted) > would be targeted at KDE SC 4.8.1 or later. > > > This addresses bug 279128. > http://bugs.kde.org/show_bug.cgi?id=279128 > > > Diffs > ----- > > core/observer.h 266993c > part-viewermode.rc dbd8e42 > part.h a4ab8aa > part.cpp cd0b695 > part.rc 33d3829 > ui/minibar.h e91a0fd > ui/minibar.cpp 7e77dec > > Diff: http://git.reviewboard.kde.org/r/103427/diff/diff > > > Testing > ------- > > Built Okular from master with these changes. Checked operation in both > embedded and standalone modes with page bar shown or not, with a variety of > PDF files. > > > Screenshots > ----------- > > With page bar shown > http://git.reviewboard.kde.org/r/103427/s/372/ > With page bar hidden > http://git.reviewboard.kde.org/r/103427/s/373/ > > > Thanks, > > Jonathan Marten > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
