https://bugs.kde.org/show_bug.cgi?id=201669
--- Comment #17 from Albert Astals Cid <tsdgeos terra es> 2010-07-27 00:42:45
---
Hi Mathieu, the patch looks impressive, some things i'd like you to fix though:
* Minor nitpicks:
* Please do not include ¿vim? modelines in the files
* For enums use capital first letter, i.e. ChangePageDirection
* For enum values use capital first letter too, i.e. Null
* You have some weird indenting like
+ else if (Okular::Settings::viewMode() ==
Okular::Settings::EnumViewMode::FacingFirstCentered )
+ {
+ facingFirst = 1;
+ reason = 2;
+ }
please make sure the {} are on the same indenting level than the previos
like if or else
And now some real problems with the behaviour:
* Select Fit Page, click on a page (not the first one) so you get only that
page and the green border surrounds the page, now go to the thumbnail view, and
press and drag down, see how the green border "jumps" up to cover the previous
page.
* If when dragging the current page changes from one to another on the main
view there is a weird effect in which it seems that the next (or previous?)
page is painted for a very small moment and then the correct page is painted
again very fast
Could you please investigate these issues?
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
