Hi! > > This is basic support for modem in Droid 4, accessed over > > ttyUSB4. That interface is unfortunately quite broken, so we need to > > force very specific SMS mode. > > > > Can you separate this into at least a couple of patches per our patch > submission guidelines? See HACKING, 'Submitting Patches' section. > > 1 - atmodem / vendor quirks > 2 - plugins/droid.c + build changes
Ok, will make it into two patches.
> > + default:
> > + /* Should be a safe fallback */
> > + snprintf(buf, sizeof(buf), "AT+CNMA=0");
> > + break;
> > + }
>
> I'd rather you just not call at_ack_delivery at all in the case of DROID.
> In fact, I don't think this function gets invoked at all if cnma_enabled is
> false...
Let me see if I can get that to work.
> > + if (getenv("OFONO_AT_DEBUG"))
> > + g_at_chat_set_debug(chat, droid_debug, "");
>
> Maybe use at_util_open_device()?
Let me take a look.
Thanks a lot for the review!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: PGP signature
_______________________________________________ ofono mailing list -- [email protected] To unsubscribe send an email to [email protected]
