Hi Lars,
On 8/19/20 7:43 AM, [email protected] wrote:
From: Lars Poeschel <[email protected]>
As the default way of getting the signal quality with +CIND is also
unstable on quectel serial modems (the same as on quectel EC21). In fact
the signal quality is only updated on cell changes. Those trigger a
manual AT+CSQ in ofono and get an update this way, but the URCs do not
work.
So we implement a quectelish way here as well.
--- >8 ---
I send this patch as a RFC because the quectel_csqn_notify function
very much duplicates the ifx_xcsq_notify function despite the "+CSQN"
string. I did not see a good way to reuse the already existing
function because the callback interface only has one user defined
pointer and this is used by the struct ofono_netreg pointer already.
Does anyone have a better idea ?
You could take advantage of the fact that at_netreg_data carries the vendor id
in nd->vendor. So if you wanted to make ifx_xcsq_notify you could do something
like:
struct ofono_netreg *netreg = user_data;
struct at_netreg_data *nd =
ofono_netreg_get_data(netreg);
switch (nd->vendor) {
case ...
prefix = "+XCSQ:";
break;
case ...
prefix = "+CSQN:";
break;
}
....
Or just put the meat of ifx_xcsq_notify into a separate function that takes the
prefix as a parameter...
Then ifx_xcsq_notify might look something like:
netreg_generic_strength_report("+XCSQ:");
Thanks,
Lars
---
drivers/atmodem/network-registration.c | 34 ++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
Regards,
-Denis
_______________________________________________
ofono mailing list -- [email protected]
To unsubscribe send an email to [email protected]
