Hello Denis, > > Function gemalto_modem_ready attempts to restart AT chat data->app > > after incomplete shutdown. As a result, new AT chat does not work > > as expected loosing AT commands. > > > > Signed-off-by: Sergey Matyukevich <[email protected]> > > --- > > plugins/gemalto.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Patch 2, 3 look good to me. > > For this one, what is it trying to do actually? >
Thanks for review. I will re-send second revision of the patches 1-3 with minor changes according to review comments. Concerning the 4th patch, I thought the problem was in the incomplete cleanup on data->app re-open in gemalto_modem_ready function. However this is not the case. Sometimes, in particular on cold start, modem is not really ready even after it sends ^SYSSTART. As a result, subsequent AT+CFUN=4 command never completes. I have been experimenting with the same approach as in ublox plugin with much better results. So I will complete my experiments and send new fix in a separate patch. Regards, Sergey _______________________________________________ ofono mailing list -- [email protected] To unsubscribe send an email to [email protected]
