Hi, What about this question?
On Wed, Oct 10, 2018 at 10:09 AM Giacinto Cifelli <[email protected]> wrote: > > Dear all, > > I have a question for shared functions among atoms, but vendor-specific. > > For Gemalto, I have these two for now: > > gboolean gemalto_get_auth_command(struct ofono_modem *modem, int cid, > enum ofono_gprs_auth_method auth_method, > const char *username, const char *password, > char *buf, guint buflen); > > void gemalto_get_cgdcont_command(struct ofono_modem *modem, > guint cid, enum ofono_gprs_proto proto, const char *apn, > char *buf, guint buflen); > > that will be used by gprs-context and lte atoms. > > I saw that also uBlox might benefit from the same shared functions, > because they prepend "PAP:" or "CHAP:" to the APN name if the > authentication is used. > For other vendors I don't know because the specifications are not > public, but there are loads of URC-parsing functions, sometimes > already duplicated. > > I would like to set my functions in atmodem/utils.c, with headers in > atmodem/utils.h. > But maybe it is better to use atmodem/vendor.h and create an atmodem/vendor.c > ? > Or duplicate them? > > Any suggestion is appreciated. > > thank you, > Regards, > Giacinto thanks, Giacinto _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
