On Tue, Sep 25, 2018 at 6:04 AM Denis Kenzior <[email protected]> wrote:
> Hi Giacinto,
>
> > But the VENDOR_CINTERION remains in the code, there are no changes for
> > the plugin.
> >
>
> That's exactly the point. You have taken out all VENDOR_CINTERION
> logic, yet plugins/gemalto.c still sets VENDOR_CINTERION for the sim
> atom. So now you broke that driver. Your change set is not
> self-contained. If I apply this patch and you get hit by a bus
> tomorrow, the plugin remains broken for everyone.
>
It is not taken out. It is:
case OFONO_VENDOR_CINTERION:
case OFONO_VENDOR_GEMALTO:
if (g_at_chat_send(sd->chat, "AT^SPIC", gemalto_spic_prefix,
gemalto_spic_cb, cbd, g_free) > 0)
both are there, and the functions are renamed, but still there.
Or shall I duplicate the functions for the time being?
>
> Regards,
> -Denis
>
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
