On 25/06/18 18:40, Denis Kenzior wrote:
Hi Slava,

On 06/21/2018 12:20 PM, Slava Monich wrote:
---
  include/types.h | 31 +++++++++++++++++++++++++++++++
  1 file changed, 31 insertions(+)


Can you help me understand what is the motivation behind this?  In the past we opted not to expose OFONO enums for well-known values (e.g. those defined in 27.007).

Obviously I didn't know that it was a conscious decision. Feel free to ignore all those patches then. It's just I have very low tolerance to duplicate definitions and magic numbers.

common.h is not available to dynamically loadable plugins built against ofono devel package.

Also, enum ofono_clir_option (which seems to be a 27.007 thing too) is defined in include/types.h which is a bit inconsistent.

Oh well.

-S.
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to