On Wed, Dec 1, 2010 at 8:24 PM, <[email protected]> wrote: > Hi Lucas, > >> +enum ofono_radio_band_gsm { >> + OFONO_RADIO_BAND_GSM_ANY = 0, >> + OFONO_RADIO_BAND_GSM_850 = 1, >> + OFONO_RADIO_BAND_GSM_900P = 2, >> + OFONO_RADIO_BAND_GSM_900E = 3, >> + OFONO_RADIO_BAND_GSM_1800 = 4, >> + OFONO_RADIO_BAND_GSM_1900 = 5, >> +}; >> + >> +enum ofono_radio_band_umts { >> + OFONO_RADIO_BAND_UMTS_ANY = 0, >> + OFONO_RADIO_BAND_UMTS_850 = 1, >> + OFONO_RADIO_BAND_UMTS_900 = 2, >> + OFONO_RADIO_BAND_UMTS_1700AWS = 3, >> + OFONO_RADIO_BAND_UMTS_1900 = 4, >> + OFONO_RADIO_BAND_UMTS_2100 = 5, >> +}; > > A minor coding style comment. Accodring to code style M11: Naming of > enums, > If the enum contents have values (e.g. from specification) then the
What I understood is that "specification" is just an example, it might be because of other things. But I agree with your comment. Thanks, fixed. Lucas De Marchi _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
