Hi Yang, On 25 November 2010 13:28, Yang Gu <[email protected]> wrote: > This series of patch is to add provide local info support by requesting the > terminal to send time and language info. Please comment on the following > aspects as I'm not sure after reading the spec: > 1. Timezone may be a number in the range -47 through +48. In struct sms_scts, > timezone is defined as gint8, thus 0xFF should shand for -1, which is a valid > input. Thus I think build_dataobj_datetime_timezone() in src/stkutil.c is not > correct. But I'm still not sure what value should be passed to oFono when > timezone is absent.
I think you're right that build_dataobj_datetime_timezone() is wrong. Also note that sms_decode_scts() and sms_encode_scts() only allow the range -47 to 47, 48 would return an error. I'm not sure what the unknown time zone should be represented as, here are some options: * 0 (same as no offset) * 0xff because there's currently no GMT-00:15 time zone on earth (http://en.wikipedia.org/wiki/List_of_time_zones_by_country) * 0x80 (a currently unused value could be #defined as unknown time zone) * the struct could be extended with a .has_tz boolean. > 2. DBUS_TYPE_BYTE represents an 8-bit unsigned integer, and D-Bus doesn't > have a type related to 8-bit signed integer. So what's the best way to > represent a timezone? Maybe instead of asking D-bus, ofono should use tzset() to retrieve the time zone information and use localtime() for the other fields? > 3. Only one byte is used to represent the year. Is the following logic > correct to get the year with one byte? > if (year_dbus >= 2000) > year = year_dbus - 2000; > else > year = year_dbus - 1900; I believe this is correct. Best regards _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
