Thank you! I updated the language accordingly, and added a warning in the security section aligned with Annabelle’s concerns. Updating the draft shortly.
From: Brian Campbell <bcampb...@pingidentity.com> Date: Thursday, March 26, 2020 at 09:47 To: Vittorio Bertocci <vittorio.berto...@auth0.com> Cc: George Fletcher <gffle...@aol.com>, Brian Campbell <bcampbell=40pingidentity....@dmarc.ietf.org>, oauth <oauth@ietf.org> Subject: Re: [OAUTH-WG] WGLC on "JSON Web Token (JWT) Profile for OAuth 2.0 Access Tokens" Preventing token substitution/confusion was not at all the aim of my comment. I only brought that up in an attempt to bridge what looked like a communication gap in Annabelle's and your discussion. Sorry for any confusion that might have caused. That discussion did lead me to think again about the more general issue of signalling/figuring out what key from jwks_uri (which has content that isn't static and likely changes over time for key rotation) used to sign. Then looking again at draft-ietf-oauth-access-token-jwt-04 to realize that it's pretty much silent about this bit that I think is an important aspect to interop. The text you suggested definitely works better, yes. Thank you. I could say that there'd be value in saying more but, as previously promised, I won't argue it further. On Wed, Mar 25, 2020 at 5:46 PM Vittorio Bertocci <vittorio.berto...@auth0.com<mailto:vittorio.berto...@auth0.com>> wrote: I think I am missing something here. It’s not that I don’t want to give guidance, is that it seems that the guidance you are thinking of isn’t necessary unless we think that enforcing explicitkey-token type assignment declaration is necessary. I didn’t get the impression that it was the proposal so far, what I have read was “if the intent was to prevent token confusion/substitution, this is insufficient”, to which the answer was “that was not the intent”. And if preventing token substitution/confusion is not the aim, then the only guidance required here to the RS is “expect that any key published in the doc pointed by jwks_uri could be used to sign the AT” which seems actionable enough. I do agree that the language could be more explicitly aimed at that outcome.. Would something to the effect of “The RS should expect the AS to use any of the keys published in the JWKS doc to sign JWT ATs” work better? From: Brian Campbell <bcampb...@pingidentity.com<mailto:bcampb...@pingidentity.com>> Date: Wednesday, March 25, 2020 at 14:26 To: Vittorio Bertocci <vittorio.berto...@auth0.com<mailto:vittorio.berto...@auth0.com>> Cc: George Fletcher <gffle...@aol.com<mailto:gffle...@aol.com>>, Brian Campbell <bcampbell=40pingidentity....@dmarc.ietf.org<mailto:40pingidentity....@dmarc.ietf.org>>, oauth <oauth@ietf.org<mailto:oauth@ietf.org>> Subject: Re: [OAUTH-WG] WGLC on "JSON Web Token (JWT) Profile for OAuth 2.0 Access Tokens" It seems to me that leaving that out of scope is rather antithetical to the previously stated reason for the profile using only asymmetric signatures, namely that "this profile focuses on a solution that is as close to turnkey as possible for developers." And I'd suggest that, to borrow your words, looking at this from the useful guidance standpoint rather than the “lawyering up” perspective, some guidance on determining the correct key to use from the keys at the jwks_uri to verify the signature on the AT would be very useful in general and also prevent the kind of potential missteps you described. I mean, if nothing is said about it or even if it'd said to be out of scope, a working interoperable approach could probably be inferred by knowing and applying bits of JWS, JWA, JWK, etc.. But, to me anyway, it seems incongruent to expect folks to figure all that out but at the same time believe them capable of mistakes that would be prevented by only pointing out that ATs and ID tokens might be signed by different keys. FWIW there's some ~8 year old text in OIDC that kinda attempts to give that kind of guidance in the Asymmetric bit of https://openid.net/specs/openid-connect-core-1_0.html#Signing and https://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys - it's not perfect (this issue<https://bitbucket..org/openid/connect/issues/1161/key-rotation-should-require-a-delay> was raised just recently) but attempts to convey how verification key selection is to be done and account for key rotation too. This seems rather cut and dry to me but maybe I'm "in the weeds" on this one. And I've spent more time here than I'd like to admit so I won't argue it further. On Wed, Mar 25, 2020 at 12:57 PM <vittorio.berto...@auth0.com<mailto:vittorio.berto...@auth0.com>> wrote: That works for me! From: George Fletcher <gffle...@aol.com<mailto:gffle...@aol.com>> Sent: Wednesday, March 25, 2020 11:56 AM To: vittorio.berto...@auth0.com<mailto:vittorio.berto...@auth0.com>; 'Brian Campbell' <bcampbell=40pingidentity....@dmarc.ietf.org<mailto:40pingidentity....@dmarc.ietf.org>> Cc: 'Brian Campbell' <bcampb...@pingidentity.com<mailto:bcampb...@pingidentity.com>>; 'oauth' <oauth@ietf.org<mailto:oauth@ietf.org>> Subject: Re: [OAUTH-WG] WGLC on "JSON Web Token (JWT) Profile for OAuth 2.0 Access Tokens" If we don't want to give guidance on how the RS determines the correct key to use to validate the token, then maybe we should state that explicitly. "The mechanism used by the RS to determine the correct key to use to validate the access token is out of scope for this specification". That way at least we are being very clear that the spec is not trying to specify how that happens. Thoughts? On 3/25/20 2:44 PM, vittorio.berto...@auth0.com<mailto:vittorio.berto...@auth0.com> wrote: Brian, there are plenty of ways in which an RS can surprise you with odd behavior- for example, developers might see that you used a key for signing an IDtoken and use that for init all their validation middleware for ATs as well, say because the library only supports one key at a time, and then end up failing at runtime when/if the assumption ceases to apply in the future.. Would that be legitimate of them to take such a dependency, even without warning text? No. However I am not looking at this from the “lawyering up” perspective, but from the useful guidance standpoint as well. I am well aware that being concise is a feature, but I am also not crazy about making every specification into an intelligence test for the reader. If a 16 words sentence can help prevent a likely misstep, I’d be inclined to keep it.. But if the consensus is that the sentence is confusing, I can also take it out. Brian & George, in the spirit of keeping things simple, and given that this was more of a “just in case” warning rather than a security feature clamored for- if the language is problematic I’d be more inclined to take the sentence out rather than complicating the guidance further. From: Brian Campbell <bcampbell=40pingidentity....@dmarc.ietf.org><mailto:bcampbell=40pingidentity....@dmarc.ietf.org> Sent: Wednesday, March 25, 2020 11:21 AM To: George Fletcher <gffle...@aol.com><mailto:gffle...@aol.com> Cc: Brian Campbell <bcampb...@pingidentity.com><mailto:bcampb...@pingidentity.com>; Vittorio Bertocci <vittorio.berto...@auth0.com><mailto:vittorio.berto...@auth0.com>; oauth <oauth@ietf.org><mailto:oauth@ietf.org> Subject: Re: [OAUTH-WG] WGLC on "JSON Web Token (JWT) Profile for OAuth 2.0 Access Tokens" I don't think you are missing anything, George (except that, to be pedantic, `kid` is a header rather than a claim). The question gave me pause, however, and makes me think that maybe the draft, with the aim of improved interoperability, should have some more explicit text about the use of the 'kid' header in a JWT AT and how it references the verification key in the content at the jwks_uri. On Wed, Mar 25, 2020 at 11:54 AM George Fletcher <gffletch=40aol....@dmarc.ietf.org<mailto:gffletch=40aol....@dmarc.ietf.org> <mailto:40aol....@dmarc.ietf.org><mailto:40aol....@dmarc.ietf.org> > wrote: Can we not use the 'kid' claim to inform the RS as to which key is being used? What am I missing? On 3/25/20 1:51 PM, Brian Campbell wrote: I think, even without that statement in the draft, that ASes already have license to use different keys if they so choose. And maybe I'm not creative enough but I can't think of what problematic assumptions RSes might make that would prevented by it. So perhaps just removing that whole sentence, "An authorization server MAY elect to use different keys to sign id_tokens and JWT access tokens."? Just a thought anyway. On Wed, Mar 25, 2020 at 10:11 AM <vittorio.bertocci= 40auth0....@dmarc.ietf.org<mailto:40auth0....@dmarc.ietf.org> <mailto:40auth0....@dmarc.ietf.org><mailto:40auth0....@dmarc.ietf.org> > wrote: Thank you for the perspective- I guessed something similar (“there would be no way for the RS to know what key is used for what"). As stated below, the intent wasn’t to prevent substitution/confusion, but mostly to give ASes license to use different keys if they choose to (for the reasons listed below, or any other reason they might have) and a headsup to RSes so that they don’t make assumptions. *From:* Brian Campbell <mailto:bcampbell=40pingidentity....@dmarc.ietf.org><mailto:bcampbell=40pingidentity....@dmarc.ietf.org> <bcampbell=40pingidentity....@dmarc.ietf.org><mailto:bcampbell=40pingidentity....@dmarc.ietf.org> *Sent:* Wednesday, March 25, 2020 8:48 AM *To:* Vittorio Bertocci <mailto:vittorio.berto...@auth0.com><mailto:vittorio.berto...@auth0.com> <vittorio.berto...@auth0.com><mailto:vittorio.berto...@auth0.com> *Cc:* Richard Backman, Annabelle <mailto:richa...@amazon.com><mailto:richa...@amazon.com> <richa...@amazon.com><mailto:richa...@amazon.com>; oauth < oauth@ietf.org<mailto:oauth@ietf.org> <mailto:oauth@ietf.org><mailto:oauth@ietf.org> > *Subject:* Re: [OAUTH-WG] WGLC on "JSON Web Token (JWT) Profile for OAuth 2.0 Access Tokens" I'm gonna go out on a limb and guess/suggest that implicit in Annabelle's comment was an assumption that signing ATs and ID Tokens with different keys would be done to prevent token substitution/confusion. And there's not really a practical way to achieve that with the mechanics of the jwks_uri.. On Wed, Mar 25, 2020 at 3:53 AM Vittorio Bertocci <vittorio.bertocci= 40auth0....@dmarc.ietf.org<mailto:40auth0....@dmarc.ietf.org> <mailto:40auth0....@dmarc.ietf.org><mailto:40auth0....@dmarc.ietf.org> > wrote: *>§4 p3: The only practical way for the AS to sign ATs and ID Tokens with different keys is to publish the keys in two different JWK sets. This only way to do this today is by publishing separate OAuth 2.0 authorization server metadata and OIDC Discovery metadata files, where the JWK set in the former applies to access tokens and the JWK set in the latter applies to ID Tokens.* Hmm, I don’t follow. The OIDC jwks_uri can contain multiple keys, and they all can be used for signing. What prevents the AS to use one key from that list for IDtokens and another for ATs? Separate discovery docs shouldn’t be necessary. Sure, there would be no way for the RS to know what key is used for what- but similar mechanisms are already in place today for handling signing key rotation: e.g. the discovery doc lists the current key and the future key, but uses only the current- and the RS has no way of distinguishing between the two. The situation here can be analogous, any key in the discovery doc should be considered valid by the RS, and in fact there’s no requirement about selecting specific keys in the validation section. That doesn’t mean this is useless, an AS might elect to use different keys for its own purposes (eg separation of concerns for forensics, different strengths, different lifecycles, and so on). *CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited... If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you.* _______________________________________________ OAuth mailing list OAuth@ietf.org<mailto:OAuth@ietf.org> <mailto:OAuth@ietf.org><mailto:OAuth@ietf.org> https://www.ietf.org/mailman/listinfo/oauth _______________________________________________ OAuth mailing list OAuth@ietf.org<mailto:OAuth@ietf.org> <mailto:OAuth@ietf.org><mailto:OAuth@ietf.org> https://www.ietf.org/mailman/listinfo/oauth -- [Image removed by sender. Ping Identity]<https://www.pingidentity.com/> Brian Campbell Distinguished Engineer bcampb...@pingidentity.com<mailto:bcampb...@pingidentity.com> w: +1 720.317.2061 c: +1 303.918.9415 Connect with us: [Image removed by sender. Glassdoor logo]<https://www.glassdoor.com/Overview/Working-at-Ping-Identity-EI_IE380907.11,24.htm>[Image removed by sender. LinkedIn logo]<https://www.linkedin.com/company/21870>[Image removed by sender. twitter logo]<https://twitter.com/pingidentity>[Image removed by sender. facebook logo]<https://www.facebook.com/pingidentitypage>[Image removed by sender. youtube logo]<https://www.youtube.com/user/PingIdentityTV>[Image removed by sender. Blog logo]<https://www.pingidentity.com/en/blog.html> [Image removed by sender.]<https://www.pingidentity.com/en/lp/e/enabling-work-from-home-with-MFA.html> If you’re not a current customer, click here<https://www.pingidentity.com/en/lp/e/work-from-home-sso-mfa.html?utm_source=Email&utm_campaign=WF-COVID19-New-EMSIG> for a more relevant offer. CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you. CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you.
_______________________________________________ OAuth mailing list OAuth@ietf.org https://www.ietf.org/mailman/listinfo/oauth
