Thanks for your review, Stephen. I've added the working group to the thread so they're aware of your comments.
> -----Original Message----- > From: Stephen Farrell [mailto:stephen.farr...@cs.tcd.ie] > Sent: Thursday, October 02, 2014 5:03 AM > To: The IESG > Cc: oauth-cha...@tools.ietf.org; draft-ietf-oauth-json-web- > to...@tools.ietf.org > Subject: Stephen Farrell's Discuss on draft-ietf-oauth-json-web-token-27: > (with > DISCUSS and COMMENT) > > Stephen Farrell has entered the following ballot position for > draft-ietf-oauth-json-web-token-27: Discuss > > When responding, please keep the subject line intact and reply to all email > addresses included in the To and CC lines. (Feel free to cut this introductory > paragraph, however.) > > > Please refer to http://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > http://datatracker.ietf.org/doc/draft-ietf-oauth-json-web-token/ > > > > ---------------------------------------------------------------------- > DISCUSS: > ---------------------------------------------------------------------- > > > (1) 4.1.1 and elsewhere you say case-sensitive: the same thing I raised wrt > DNS > names for another JOSE spec - do you need to say those SHOULD be > [upper|lower]cased when used in these? I believe that somewhere we should say that if case-insensitive values, such as DNS names, are used when constructing "kid" values, that the application doing so needs to define a convention on the canonical case to use for the case-insensitive portions, such as lowercasing them. > (2) Section 8: Why is "none" MTI? That seems both broken and going in the > oppostite direction from other WGs and so should be explicitly jusified I > think. (If > a good enough justification exists that is.) It is MTI because there are several existing applications of JWTs in which both unsigned and signed representations of the JWTs are requirements. These include draft-ietf-oauth-token-exchange, draft-hunt-oauth-v2-user-a4c, and OpenID Connect. This is a pretty common pattern where you sign something if the recipient cares who made the statements and where you don't have to sign it either if the recipient doesn't care who made the statements or if it can tell from another secured aspect of the application protocol (typically through the use of TLS) who made the statements. In the TLS case, the server authentication step makes a signature step unnecessary, so an Unsecured JWT is fine there. > (3) Section 12: another way to handle privacy is to not include sensitive > data - I > think you ought mention that as a bit of thought along those lines can be much > simpler than putting in place the key management to handle thoughtlessly > included PII. We can include a discussion of that point, but sometimes the very point of a JWT is to securely deliver PII from a verifiable party to an intended party with appropriate rights to receive it. > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > > - abstract: 2nd sentence isn't needed here, in intro would be fine. I don't know - I think it's a big deal that the claims can be digitally signed or MACed and/or encrypted. That's the reason we have JWTs, rather than just JSON. > - 4.1.7: maybe worth adding that jti+iss being unique enough is not > sufficient and > jti alone has to meet that need. In > X.509 the issuer/serial has the equivalent property so someone might assume > sequential jti values starting at 0 are ok. Makes sense to add a warning of some kind along these lines. I think I know the reasons you say that, but can you expand on that thought a bit before I take a stab on writing this up? For instance, while normally true, I don't think your observation is true if a relying party will only accept tokens from a single issuer. > - section 6: yuk > > - again I think the secdir comments are being handled by Kathleen and the > authors. Again, this is there because multiple applications asked for the ability to represent content that is optionally signed, sometimes securing it another way, such as with TLS. JWTs are used specific application protocol contexts - not in isolation. Thanks again, -- Mike _______________________________________________ OAuth mailing list OAuth@ietf.org https://www.ietf.org/mailman/listinfo/oauth
