thomasmueller commented on code in PR #3139:
URL: https://github.com/apache/jackrabbit-oak/pull/3139#discussion_r4132914631
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/SQL2Parser.java:
##########
@@ -740,8 +749,27 @@ private DynamicOperandImpl parseExpressionFunction(String
functionName) throws P
PropertyValueImpl pv = parsePropertyValue(readName());
read(",");
op = factory.propertyValue(pv.getSelectorName(),
pv.getPropertyName(), readString().getValue(Type.STRING));
+ } else if ("IF".equalsIgnoreCase(functionName)) {
+ DynamicOperandImpl condition = parseDynamicOperand();
+ read(",");
+ DynamicOperandImpl trueValue = parseDynamicOperand();
+ read(",");
+ DynamicOperandImpl falseValue = parseDynamicOperand();
+ op = factory.ifOperand(condition, trueValue, falseValue);
+ } else if ("EXISTS".equalsIgnoreCase(functionName)) {
+ op = factory.existsOperand(parseDynamicOperand());
+ } else if ("OP".equalsIgnoreCase(functionName)) {
Review Comment:
Yes, I found the tests for both the SQL-2 parsing (query time;
SQL2ParserTest testOpXyz) as well as the index time (FunctionIndexUtilsTest)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
