mkapalka commented on code in PR #3154:
URL: https://github.com/apache/jackrabbit-oak/pull/3154#discussion_r4095457448
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -58,6 +58,13 @@ public class ElasticBulkProcessorHandler {
private static final Logger LOG =
LoggerFactory.getLogger(ElasticBulkProcessorHandler.class);
private static final LogSilencer LOG_SILENCER = new
LogSilencer(Duration.ofSeconds(5).toMillis(), 50);
+ public static final String FT_OAK_12415 = "FT_OAK-12415";
+ /**
+ * When {@code true} (default), update operations set {@code
retry_on_conflict} so Elasticsearch re-applies
+ * a conflicting update instead of dropping it. Set to {@code false} to
revert to the legacy behaviour.
+ */
+ public static final AtomicBoolean FT_OAK_12415_ENABLE = new
AtomicBoolean(true);
Review Comment:
It's better to move this feature toggle to `ElasticFeatureToggles` -- class
`ElasticBulkProcessorHandler` is exported and therefore we won't be able to
remove any feature toggle from it without introducing a breaking change.
You can also add at "time bomb" test so that we remember to remove this FT,
e.g., in 1 year. See, e.g.,
https://github.com/apache/jackrabbit-oak/commit/9595d3fde56a1e8e6f75afafc487bde947659bdd#diff-a38dba0e7b248a563cf55bab5132c877888dcc0f913bb61b3f654a40524fd106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
