fabriziofortino commented on code in PR #3079:
URL: https://github.com/apache/jackrabbit-oak/pull/3079#discussion_r3863637764
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java:
##########
@@ -350,9 +350,13 @@ private static void mapIndexRules(@NotNull
TypeMapping.Builder builder,
for (PropertyDefinition pd :
indexDefinition.getDynamicBoostProperties()) {
builder.properties(ElasticIndexUtils.fieldName(pd.nodeName),
b1 -> b1.nested(
+ // norms disabled: values sharing a boost
score are grouped into a single nested
+ // doc (see ElasticDocument#FT_OAK_12353), so
field length varies by group size and
+ // would otherwise skew BM25 length
normalization; boost is applied explicitly via
+ // field_value_factor, so length normalization
on this field isn't meaningful anyway.
Review Comment:
this was a separate optimization that I thought would be beneficial. But
@ChlineSaurus pointed out an issue (see the other comment). This has been
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
