fabriziofortino commented on code in PR #2949:
URL: https://github.com/apache/jackrabbit-oak/pull/2949#discussion_r3524560573
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextIndexEditorContext.java:
##########
@@ -121,6 +124,10 @@ protected FulltextIndexEditorContext(NodeState root,
NodeBuilder definition,
public abstract DocumentMaker<D>
newDocumentMaker(IndexDefinition.IndexingRule rule, String path);
+ public boolean isTypeChangeTrackingEnabled() {
+ return typeChangeTrackingEnabled;
+ }
+
Review Comment:
I would remove this and rollback all the changes in this class. The
`typeChangeTrackingEnabled` is always based on the FT flag and
`isTypeChangeTrackingEnabled` is only called in `FulltextIndexEditor` that
defines the toggle. Since the toggle should be removed after a while, I propose
rollback the changes in this class and explicitly check the FT flag instead of
calling `context.isTypeChangeTrackingEnabled()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
