thomasmueller commented on code in PR #2964:
URL: https://github.com/apache/jackrabbit-oak/pull/2964#discussion_r3442339748
##########
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java:
##########
@@ -481,6 +497,10 @@ public void close() {
if (s3PresignService != null) {
s3PresignService.close();
}
+ closePresignClient();
+ if (sdkTimeoutExecutor != null) {
+ sdkTimeoutExecutor.shutdownNow();
Review Comment:
Why not just shutdown()? shutdownNow() calls Thread.interrupt, which is
dangerous because it can close files, including Lucene files and persistent
cache files, when called at the wrong time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
