fabriziofortino commented on code in PR #2925:
URL: https://github.com/apache/jackrabbit-oak/pull/2925#discussion_r3340723639
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionTest.java:
##########
@@ -76,4 +106,40 @@ public void indexPrefixWithNotAllowedChars() {
.withDefaultConnectionParameters()
.build();
}
+
+ @Test
+ public void responseExecutorIsDedicatedAndStableByDefault() throws
IOException {
+ try (ElasticConnection connection = defaultConnection()) {
+ Executor executor = connection.getResponseExecutor();
+ // the dedicated executor decouples async response processing from
the common pool (OAK-12234)
+ assertNotSame(ForkJoinPool.commonPool(), executor);
+ // the same executor instance is reused across calls
+ assertSame(executor, connection.getResponseExecutor());
Review Comment:
makes sense. Assertion removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
