thomasmueller commented on code in PR #2784:
URL: https://github.com/apache/jackrabbit-oak/pull/2784#discussion_r3332594340


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java:
##########
@@ -132,7 +138,18 @@ public PropertyIndexEditor(NodeBuilder definition, 
NodeState root,
 
         // get property names
         PropertyState names = definition.getProperty(PROPERTY_NAMES);
-        if (names.count() == 1) { 
+        if (names == null && 
Boolean.parseBoolean(System.getProperty(FT_GRANITE_63829))) {

Review Comment:
   So far we throw a NullPointerException. We could argue a feature toggle is 
not needed in this case. But let's add one anyway (possibly NPE is better than 
not throwing a NPE, for some weird reason).
   
   Please use a feature toggle like other we use, see 
oak-core-spi/src/main/java/org/apache/jackrabbit/oak/spi/toggle/FeatureToggle.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to