rishabhdaim opened a new pull request, #2788: URL: https://github.com/apache/jackrabbit-oak/pull/2788
## Summary Removes the `toCompletableFuture(ListenableFuture)` and `toCompletableFuture(List<ListenableFuture>)` methods from `FutureConverter` as part of the ongoing Guava removal effort. These methods are no longer needed now that callers have been migrated to native JDK `CompletableFuture`. The `toListenableFuture(CompletableFuture)` method is retained as it is still needed by existing callers. ## Changes - `FutureConverter.java` — removed both `toCompletableFuture` overloads, the `handleConversion` private helper, and the `DIRECT_EXECUTOR` field; cleaned up unused imports (`List`, `Collectors`) - `FutureConverterTest.java` — removed all 10 tests covering `toCompletableFuture`; removed `SettableFuture`, `Arrays`, `List` imports - `package-info.java` — bumped package version `1.3.0` → `2.0.0` (removing public methods is a major API change per OSGi semantic versioning) ## Test Plan - [ ] `mvn clean install -DskipTests=true -pl oak-commons -am` passes (baseline check included) - [ ] Remaining `FutureConverterTest` tests (`toListenableFuture*`) pass ## Links - JIRA: https://issues.apache.org/jira/browse/OAK-12132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
