rishabhdaim opened a new pull request, #2786:
URL: https://github.com/apache/jackrabbit-oak/pull/2786

   ## Summary
   
   Removes all Guava `TreeTraverser` usages from `TraverserTest` now that the 
native `Traverser` implementation is in place.
   
   ## Changes
   
   - `TraverserTest.java`:
     - Removed `import org.apache.jackrabbit.guava.common.collect.TreeTraverser`
     - Removed `TreeTraverser<Node> traverser` field (anonymous subclass)
     - Removed 3 `*WithGuava` tests that compared against Guava's behaviour 
(`testPreOrderTraversalWithNullChildrenWithGuava`, 
`testBreadthFirstTraversalWithNullChildrenWithGuava`, 
`testPostOrderTraversalWithNullChildrenWithGuava`)
     - Removed 3 random-tree parity tests that asserted equality with Guava's 
output (`testPreOrderTraversalWithRandomTree`, 
`testBreadthFirstOrderTraversalWithRandomTree`, 
`testPostOrderTraversalWithRandomTree`)
     - Removed stray `traverser.postOrderTraversal(null)` assertion from 
`testPostOrderTraversalWithNullRoot`
   
   ## Test Plan
   
   - [ ] All remaining `TraverserTest` tests pass
   - [ ] No Guava imports remain in the file
   
   ## Links
   
   - JIRA: https://issues.apache.org/jira/browse/OAK-12130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to