alagodasii commented on code in PR #2613: URL: https://github.com/apache/jackrabbit-oak/pull/2613#discussion_r2559156376
########## oak-core/src/test/java/org/apache/jackrabbit/oak/query/xpath/XPathToSQL2Test.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.jackrabbit.oak.query.xpath; + +import static org.junit.Assert.assertEquals; + +import java.text.ParseException; + +import org.apache.jackrabbit.oak.query.QueryEngineSettings; +import org.apache.jackrabbit.oak.spi.toggle.Feature; +import org.junit.Test; +import org.mockito.Mockito; + +/** + * Tests for XPathToSQL2Converter focusing on the OR-to-UNION conversion behavior + * controlled by the optimizeXPathUnion feature toggle. + */ +public class XPathToSQL2Test { + + @Test + public void testOrToUnionConversionFeatureDisabled() throws ParseException { Review Comment: It's a matter of preference, but for maintainability mainly. It's easier to compare inputs vs outputs and detect possible duplicate/missing scenario. It also makes purpose of this method more understandable to the reader, that it only serves single purpose and doesn't require additional setup. But as I said at the beginning - matter of preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
