jsedding commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260672887
##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:
##########
@@ -89,7 +96,7 @@ public boolean segmentFilesExist() {
@Override
public JournalFile getJournalFile() {
- return new AzureJournalFile(readBlobContainerClient,
writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController);
+ return new AzureJournalFile(readBlobContainerClient,
writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController,
journalLineLimit);
Review Comment:
I wanted to use the way `AzurePersistence` constructs `AzureJournalFile`,
because the bug was introduced by changing the arguments of the
`AzureJournalFile` constructor.
However, by doing that, I needed a way to feed the `journalLineLimit`
through `AzurePersistence`. I'm more than happy if you see a better way to
achieve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
