mreutegg commented on code in PR #1892:
URL: https://github.com/apache/jackrabbit-oak/pull/1892#discussion_r2236672616


##########
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/RemoteUtilities.java:
##########
@@ -50,4 +51,17 @@ public static UUID getSegmentUUID(@NotNull String 
segmentFileName) {
         }
         return UUID.fromString(m.group(2));
     }
+
+    public static class ArchiveIndexComparator implements Comparator<String> {

Review Comment:
   Looks good. Though, I would not expose the inner class. You could make it 
private and available as a public static field of type `Comparator<String>`.
   ```
       public static final Comparator<String> ARCHIVE_INDEX_COMPARATOR = new 
ArchiveIndexComparator();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to