rishabhdaim commented on code in PR #2380:
URL: https://github.com/apache/jackrabbit-oak/pull/2380#discussion_r2198023202


##########
oak-run/src/main/java/org/apache/jackrabbit/oak/run/DataStoreCommand.java:
##########
@@ -574,8 +575,6 @@ static class VerboseIdLogger {
                 return s1.split(DELIM)[0].compareTo(s2.split(DELIM)[0]);
             }
         };
-        private final static Splitter delimSplitter = 
Splitter.on(DELIM).trimResults().omitEmptyStrings();
-

Review Comment:
   I am not sure how that would avoid repetition. This is only used once in the 
code.
   
   `            List<String> list = Arrays.stream(line.split(DELIM))
                       .map(String::trim)
                       .filter(s -> !s.isEmpty())
                       .collect(Collectors.toList());`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to