mbaedke commented on code in PR #2371:
URL: https://github.com/apache/jackrabbit-oak/pull/2371#discussion_r2192317124
##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/xml/ImportHandler.java:
##########
@@ -136,8 +140,7 @@ public void endDocument() throws SAXException {
public void startPrefixMapping(String prefix, String uri)
throws SAXException {
try {
- new NamespaceHelper(sessionContext.getSession()).registerNamespace(
- prefix, uri);
+ registerNamespace(prefix, uri);
Review Comment:
As discussed elsewhere: NamespaceHelper has to fetch the registry every time
because ReadonlyNamepaceRegistry internally uses Tree objects retrieved from
the Root passed to the constructor. So in order to come up with a registry
based on the current root, NamespaceHelper should create a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
